Activity pause support #482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sushisource
approved these changes
May 27, 2025
Comment on lines
+21
to
+22
| /// Gets a value indicating whether the activity timeout caused activity to be marked | ||
| /// cancelled. |
There was a problem hiding this comment.
Suggested change
| /// Gets a value indicating whether the activity timeout caused activity to be marked | |
| /// cancelled. | |
| /// Gets a value indicating whether the activity is timed out. |
Technically this can be set true without it being the cause I think?
There was a problem hiding this comment.
Without it being the singular cause, true, but it is one of the causes. I guess I was using the word "caused" here to clarify that this is not true if it is timed out, it is true if timeout was one of the causes that tripped cancellation. You can trip cancellation for something else and then timeout.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
ActivityCancellationDetailswith cancellation informationActivityExecutionContext.CancellationDetailswhich returns an instance of cancellation details upon cancelActviityCancelReason.PausedChecklist